Deleting attributes doesn't remove the blocks used in the workspace

[Luyren]

b12150, on Windows.

If you use attribute blocks in a behavior, and later delete that attribute, the used blocks will stay in the workspace, either if they are attached to the event blocks or loose somewhere. They are properly removed from the palette. Even reloading the behavior doesn't get rid of them. Trying to compile gives a "Unknown Identifier" pointing to the attribute's internal name. The issues button doesn't recognize that as a problem and shows the green checkmark.

Steps:
-Create an attribute in a behavior
-Drag its getter or setter to the work space, both loose and attached to an event.
-Delete the attribute in the attribute's tab. The blocks will stay in place.
-Try to compile and get the unknown identifier error.
-Check the issues button, which should show no warning at all.

[Justin]

I thought I had reproduced this before looking at it, but then I made some changes related to this, and now whether I test with the code before the changes or after the changes, I can't reproduce this. Not sure what happened here, but I'm wondering if you can still reproduce with the latest build.

[Luyren]

b12155, still happening. I created a brand new game after downloading this build, one scene, one behavior. Blocks attached to the event in the workspace and loose, both getters and setters, remain after I delete the attributes from the attributes panel. Though there is something different now (I don't know if I missed it last time, so not 100% sure it is new):

If I close and reopen the entire game, all the phantom blocks are converted to the "place holder" block, and the issues button shows a yellow warning mark. "Fix All" won't get rid of them, but I can click the gear icon and select "go to source", and the block gets highlighted. I've attached my logs for this whole process.

[LIBERADO]

In addition to the problem that Luyren has mentioned, I always thought that deleting an attribute should display a message similar to this: "Warning! There are blocks in the workspace that use this attribute, do you really want to delete it?"

 log-2024-02-20.zip (17.93 kB - downloaded 1517 times.)